Dan Kenigsberg has posted comments on this change.

Change subject: net: Introduce network.ip package
......................................................................


Patch Set 3: Code-Review+2

(1 comment)

raising score

https://gerrit.ovirt.org/#/c/55043/3/lib/vdsm/network/ip/address.py
File lib/vdsm/network/ip/address.py:

PS3, Line 51: defaultRoute
in a future patch - pep8ize this name as well as the validate* methods.


-- 
To view, visit https://gerrit.ovirt.org/55043
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I89ecb8fc5083f2d645887502a86e84ceddadd939
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Edward Haas <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <[email protected]>
Gerrit-Reviewer: Petr Horáček <[email protected]>
Gerrit-Reviewer: gerrit-hooks <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to