Martin Polednik has posted comments on this change. Change subject: virt: set correct permissions for hwrng device ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/54806/4/vdsm/supervdsm_api/udev.py File vdsm/supervdsm_api/udev.py: Line 84: cmd = [EXT_CHOWN, 'root:root', _HWRNG_PATH] Line 85: rc, out, err = commands.execCmd(cmd) Line 86: if err: Line 87: raise OSError(errno.EINVAL, 'Could not change ownership' Line 88: 'out %s\nerr %s' % (out, err)) > If this patch duplicates code from the usb handling code, it makes the code This is case of chicken and egg problem. No benefit is added if the duplication is removed *after* this patch. I'd argue it is even better as it gives better picture of duplicated portion. Line 89: Line 90: Line 91: @expose Line 92: def appropriateMultipathDevice(guid, thiefId): -- To view, visit https://gerrit.ovirt.org/54806 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id958a291e5a15813309928ba3d8c67828273b6c6 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
