Nir Soffer has posted comments on this change.

Change subject: vm: use the new response handling
......................................................................


Patch Set 8:

(2 comments)

https://gerrit.ovirt.org/#/c/54799/8//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: vm: use the new response handling
Line 8: 
Line 9: Let's start using the new api.method
Line 10: decoratore to handle exceptions and response
decorator
Line 11: from few methods already in need of some
Line 12: refactoring and cleanup.
Line 13: 
Line 14: Change-Id: Ib594a5cc6cd8945c24cfcb3704ad92d02102993b


Line 8: 
Line 9: Let's start using the new api.method
Line 10: decoratore to handle exceptions and response
Line 11: from few methods already in need of some
Line 12: refactoring and cleanup.
So this changes random apis? Why not wrap all apis?

We need to remove all the calls to response.success, and replace calls to 
response.error with raising the proper exception.
Line 13: 
Line 14: Change-Id: Ib594a5cc6cd8945c24cfcb3704ad92d02102993b


-- 
To view, visit https://gerrit.ovirt.org/54799
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib594a5cc6cd8945c24cfcb3704ad92d02102993b
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to