Ayal Baron has posted comments on this change. Change subject: [WIP] Simplifiying hsm.copyImage logic. ......................................................................
Patch Set 1: (2 inline comments) .................................................... File vdsm/storage/hsm.py Line 1403: for dom in domains: Line 1404: self.validateSdUUID(domains) Line 1405: Line 1406: # Avoid VM copy if one of its volume (including template if exists) ILLEGAL/FAKE Line 1407: pool.validateVolumeChain(sdUUID, srcImgUUID) as far as I'm concerned we can also get rid of this validate, just copy the entire image (as a tree, not chain). Line 1408: # Validate volume type and format Line 1409: sdCache.produce(dstSdUUID).validateCreateVolumeParams(volFormat, preallocate, volume.BLANK_UUID) Line 1410: Line 1411: domains.sort() Line 1405: Line 1406: # Avoid VM copy if one of its volume (including template if exists) ILLEGAL/FAKE Line 1407: pool.validateVolumeChain(sdUUID, srcImgUUID) Line 1408: # Validate volume type and format Line 1409: sdCache.produce(dstSdUUID).validateCreateVolumeParams(volFormat, preallocate, volume.BLANK_UUID) why produce again? Line 1410: Line 1411: domains.sort() Line 1412: for dom in domains: Line 1413: vars.task.getSharedLock(STORAGE, dom) -- To view, visit http://gerrit.ovirt.org/8509 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5db9053dabb97423611634e2bdfbdd09ec02876b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
