Saggi Mizrahi has posted comments on this change. Change subject: Fixing pep8 in vdsm/storage/fileVolume.py ......................................................................
Patch Set 2: (2 inline comments) .................................................... File Makefile.am Line 51: vdsm/storage/misc.py \ Line 52: vdsm/storage/mount.py \ Line 53: vdsm/storage/processPool.py \ Line 54: vdsm/supervdsm.py \ Line 55: vdsm/supervdsmServer.py ... \ $(NULL) Line 56: Line 57: check-local: Line 58: $(PYFLAKES) $(SUBDIRS) Line 59: $(PEP8) $(PEP8_WHITELIST) .................................................... File vdsm/storage/fileVolume.py Line 418: for i in files: Line 419: volid = os.path.splitext(os.path.basename(i))[0] Line 420: if (sdCache.produce(sdUUID). Line 421: produceVolume(imgUUID, volid). Line 422: getImage() == imgUUID): Actually just avoid the whole argument. dom = sdCache.produce(sdUUID) vol = dom.produceVolume(imgUUID, volid) if (vol.getImage() == imgUUID): Line 423: volList.append(volid) Line 424: return volList Line 425: Line 426: @classmethod -- To view, visit http://gerrit.ovirt.org/4541 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e1ce2aef9ac4be974529ecaf76d5dc5a578d92d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bing Bu Cao <[email protected]> Gerrit-Reviewer: Bing Bu Cao <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
