Petr Horáček has posted comments on this change. Change subject: net: native ovs [1]: ovs switch skeleton ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/55308/1/lib/vdsm/network/netswitch.py File lib/vdsm/network/netswitch.py: PS1, Line 45: if (('remove' in attrs and net in running_config.networks and : ovs_switch.is_ovs_net(running_config.networks[net])) or : ovs_switch.is_ovs_net(attrs)): > great idea, all right but i would do that only when we have defined 'legacy' attribute in API, until that it would be just extra handling in canonicalize.py -- To view, visit https://gerrit.ovirt.org/55308 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic056fcf8c0d36625328a90a339d4a09658683056 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
