Dan Kenigsberg has submitted this change and it was merged. Change subject: compat: mock CPopen for Python 3 testing ......................................................................
compat: mock CPopen for Python 3 testing I would like to run Vdsm unit tests in Python 3, but many tests ultimately attempt to import CPopen. The right thing to do is to remove CPopen dependency from the code, but this task is lagging. Until then, this patch drops CPopen dependecy for Python 3 only. Change-Id: I3fb1310dc538ea92879ab1097d897fd7c4e2ef96 Signed-off-by: Dan Kenigsberg <dan...@redhat.com> Reviewed-on: https://gerrit.ovirt.org/55379 Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer <nsof...@redhat.com> Reviewed-by: Piotr Kliczewski <piotr.kliczew...@gmail.com> --- M lib/vdsm/commands.py M lib/vdsm/compat.py M lib/vdsm/qemuimg.py 3 files changed, 10 insertions(+), 3 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, approved Nir Soffer: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Dan Kenigsberg: Verified -- To view, visit https://gerrit.ovirt.org/55379 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3fb1310dc538ea92879ab1097d897fd7c4e2ef96 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
