Milan Zamazal has posted comments on this change. Change subject: v2v: fix handling virt-v2v fail on stream close ......................................................................
Patch Set 2: Code-Review+1 (2 comments) OK, I just suggest improving the commit message. https://gerrit.ovirt.org/#/c/55477/2//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2016-03-28 15:38:16 +0300 Line 4: Commit: Shahar Havivi <shah...@redhat.com> Line 5: CommitDate: 2016-03-30 15:53:58 +0300 Line 6: Line 7: v2v: fix handling virt-v2v fail on stream close Handle closed stream when virt-v2v fails (?) Line 8: Line 9: when proc.stdout.read() is close it doesn't raise an error but returns Line 10: ''. Line 11: PS2, Line 9: close ... closed ... -- To view, visit https://gerrit.ovirt.org/55477 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia166c1aa03a8d62168034cd581be80ef5a3dc69e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
