Dan Kenigsberg has submitted this change and it was merged. Change subject: commands: import StringIO when AsyncProc is started ......................................................................
commands: import StringIO when AsyncProc is started This patch makes it possible to import vdsm.commands on Python 3. However, it does not make the module py3-compatible - any usage of AsyncProc under Python 3 would fail in runtime. The motivation of this patch is to allow adding more modules to the test_modules_py3 list, while causing no runtime harm to Python 3. Change-Id: I3610865945aeee3b13b8e195c749023a524ebe97 Signed-off-by: Dan Kenigsberg <[email protected]> Reviewed-on: https://gerrit.ovirt.org/55380 Continuous-Integration: Jenkins CI Reviewed-by: Piotr Kliczewski <[email protected]> --- M lib/vdsm/commands.py M tests/Makefile.am 2 files changed, 19 insertions(+), 4 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, approved Jenkins CI: Passed CI tests Dan Kenigsberg: Verified -- To view, visit https://gerrit.ovirt.org/55380 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3610865945aeee3b13b8e195c749023a524ebe97 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
