Dan Kenigsberg has posted comments on this change. Change subject: marking test as broken ......................................................................
Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/55523/1/tests/utilsTests.py File tests/utilsTests.py: Line 237: sproc.wait() Line 238: Line 239: Line 240: class PgrepTests(TestCaseBase): Line 241: @brokentest("when running './autogen.sh --system && make rpm' from fedora 23 in virtual machine, this tests fails") ./tests/utilsTests.py:241:80: E501 line too long (120 > 79 characters) "this test fails when run in a Fedora 23 virtual machine" would be enough. but the commit message should include the traceback of this failure - I was not aware of this one, and it smells like something that must be solved. Line 242: def test(self): Line 243: sleepProcs = [] Line 244: for i in range(3): Line 245: sleepProcs.append(commands.execCmd([EXT_SLEEP, "3"], sync=False, -- To view, visit https://gerrit.ovirt.org/55523 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b253deed5e18d7c65c240f4c360dd9b7b60d0c4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
