Yaniv Bronhaim has posted comments on this change. Change subject: hooks: Relocate hooking (api) module under lib ......................................................................
Patch Set 1: Code-Review-1 (3 comments) I agree with the direction but some comments https://gerrit.ovirt.org/#/c/55544/1/Makefile.am File Makefile.am: Line 82: vdsm-tool/vdsm-tool \ Line 83: $(NULL) Line 84: Line 85: PYFLAKES_BLACKLIST = \ Line 86: ./vdsm/hooking.py \ without ./ Line 87: $(NULL) Line 88: Line 89: Line 90: .PHONY: gitignore https://gerrit.ovirt.org/#/c/55544/1/lib/vdsm/Makefile.am File lib/vdsm/Makefile.am: Line 20: include $(top_srcdir)/build-aux/Makefile.subs Line 21: Line 22: SUBDIRS=common netinfo netlink tool infra profiling rpc tc network virt storage Line 23: Line 24: dist_vdsm_PYTHON = hooking.py does it work ? not better to leave it in vdsm/Makefile.am? Line 25: Line 26: dist_vdsmpylib_PYTHON = \ Line 27: __init__.py \ Line 28: cmdutils.py \ https://gerrit.ovirt.org/#/c/55544/1/vdsm/Makefile.am File vdsm/Makefile.am: Line 27 Line 28 Line 29 Line 30 Line 31 but you still have this file.. I don't think it will work if you don't mention it here -- To view, visit https://gerrit.ovirt.org/55544 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f2e0ed06d5f17885b5892bb8659c52f4542a9d9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
