Milan Zamazal has posted comments on this change. Change subject: virt: clean and modernize the destroy() path ......................................................................
Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/55534/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 3853: self.conf['vmId']) Line 3854: else: Line 3855: self.log.warning( Line 3856: "Failed to destroy VM '%s' gracefully (error=%i)", Line 3857: self.id, e.get_error_code()) Is it better to log e.get_error_code() or e.get_error_message()? Line 3858: if e.get_error_code() == libvirt.VIR_ERR_OPERATION_FAILED: Line 3859: return self._destroyVmForceful() Line 3860: return response.error('destroyErr') Line 3861: return response.success() Line 3865: self._dom.destroy() Line 3866: except libvirt.libvirtError as e: Line 3867: self.log.warning( Line 3868: "Failed to destroy VM '%s' forcefully (error=%i)", Line 3869: self.id, e.get_error_code()) Ditto. Line 3870: return response.error('destroyErr') Line 3871: return response.success() Line 3872: Line 3873: def deleteVm(self): -- To view, visit https://gerrit.ovirt.org/55534 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46296fe7ac6c13e064014298148f518ea6b1e1d8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
