Piotr Kliczewski has posted comments on this change. Change subject: guestagent: Add support for containers message ......................................................................
Patch Set 2: Code-Review-1 (4 comments) https://gerrit.ovirt.org/#/c/47519/2/lib/api/vdsmapi-schema.json File lib/api/vdsmapi-schema.json: PS2, Line 7495: guestContainers Do we need it always or should it be optional? Line 7521: '*vcpuPeriod': 'int', '*vcpuCount': 'int', '*vcpuUserLimit': 'int', Line 7522: '*ioTune': ['VmDiskDeviceTuneParams'], 'vmName': 'str', Line 7523: '*cpuUsage': 'uint', 'guestContainers': ['GuestContainerInfo']}} Line 7524: Line 7525: ## There is ordering practice which we use to define dependencies prior to its usage. Line 7526: # @GuestContainerInfo: Line 7527: # Line 7528: # Information about a container defined in the guest Vm Line 7529: # Line 7526: # @GuestContainerInfo: Line 7527: # Line 7528: # Information about a container defined in the guest Vm Line 7529: # Line 7530: # @id: Identifier of the container There is common practice to align beginning of param descriptions in line. Line 7531: # Line 7532: # @names: List of given names/aliases for the container Line 7533: # Line 7534: # @image: Name of the image the container was started from Line 7532: # @names: List of given names/aliases for the container Line 7533: # Line 7534: # @image: Name of the image the container was started from Line 7535: # Line 7536: # @command: Executed command in the container Definition for command and status is in different order than descriptions. Line 7537: # Line 7538: # @status: Status message for the container (e.g. uptime in case of Docker) Line 7539: # Line 7540: # Since: 4.18.0 -- To view, visit https://gerrit.ovirt.org/47519 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If42efd4d2743e231a5b012c2901b8cf372812898 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
