Nir Soffer has posted comments on this change. Change subject: storage: fix disconnecting multiple iSCSI sessions ......................................................................
Patch Set 1: (2 comments) Add back commments from deleted patch. I'm not sure this is enough, there may be other code assuming single session id. https://gerrit.ovirt.org/#/c/55578/1//COMMIT_MSG Commit Message: Line 6: Line 7: storage: fix disconnecting multiple iSCSI sessions Line 8: Line 9: An iSCSI connection can have multiple session. It's necessary to Line 10: disconnect all related sessions. Can you explain in the commit message why we like to have multiple sessions, and mention some numbers if you did any measurements? Line 11: Line 12: Change-Id: I0d576f6fe262d9576fb99a674ba921dc4a141a32 Line 13: Bug-Url: https://bugzilla.redhat.com/1322933 https://gerrit.ovirt.org/#/c/55578/1/vdsm/storage/storageServer.py File vdsm/storage/storageServer.py: Line 548: if self._cred != cred: Line 549: raise self.Mismatch("cred mismatch") Line 550: Line 551: def getSessionIds(self): Line 552: sids = [] Better use set() so we can compare the result in __eq__. Line 553: errors = [] Line 554: for session in iscsi.iterateIscsiSessions(): Line 555: try: Line 556: self._match(session) -- To view, visit https://gerrit.ovirt.org/55578 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d576f6fe262d9576fb99a674ba921dc4a141a32 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Pavel Gashev <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
