Adam Litke has posted comments on this change. Change subject: Introduce VolumeArtifacts ......................................................................
Patch Set 27: (2 comments) https://gerrit.ovirt.org/#/c/48097/27/tests/storage_volume_artifacts_test.py File tests/storage_volume_artifacts_test.py: Line 147: Line 148: # File volumes are always sparse regardless of format Line 149: for fmt in volume.RAW_FORMAT, volume.COW_FORMAT: Line 150: prealloc = artifacts._get_volume_preallocation(fmt) Line 151: self.assertEqual(volume.SPARSE_VOL, prealloc) > This tests the implementation instead of the behavior, so we will have to c Done Line 152: Line 153: def test_raw_volume_preallocation(self): Line 154: with self.fake_env() as env: Line 155: artifacts = env.sd_manifest.get_volume_artifacts( https://gerrit.ovirt.org/#/c/48097/27/vdsm/storage/sdm/volume_artifacts.py File vdsm/storage/sdm/volume_artifacts.py: Line 227: # If we created a new image directory, rename it to the correct name Line 228: if not self.is_image(): Line 229: self._oop.os.rename(self.artifacts_dir, self._image_dir) Line 230: Line 231: self._image_exists = True > This is unused, any reason to keep it? Nope. Removed. Line 232: Line 233: def _get_volume_preallocation(self, vol_format): Line 234: # File volumes are always sparse regardless of format Line 235: return volume.SPARSE_VOL -- To view, visit https://gerrit.ovirt.org/48097 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I352423e39a899b9b83ccf3b8f6c17ec433e9c353 Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
