Edward Haas has posted comments on this change.

Change subject: vdsm-restore-net-config: wait for links with netlink monitor
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/53968/3/vdsm/vdsm-restore-net-config
File vdsm/vdsm-restore-net-config:

PS3, Line 328:             if not down_links:
             :                 mon.stop()
             :             for event in mon:
My recommendation:

if down_links:
    for event in mon:
        if down_links:
            link_name = event.get('name')
            ....


-- 
To view, visit https://gerrit.ovirt.org/53968
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c45430925a55bb54995b91a061bc15affe15763
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phora...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com>
Gerrit-Reviewer: Petr Horáček <phora...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to