Milan Zamazal has posted comments on this change. Change subject: tests: add tests for sampling.VMBulkSampler ......................................................................
Patch Set 48: (1 comment) https://gerrit.ovirt.org/#/c/40053/48/tests/virt/bulk_sampling_test.py File tests/virt/bulk_sampling_test.py: PS48, Line 82: when=0, duration=10 > They are not arbitrary indeed: for most of the test I need to start with an Please add the explanation. I wonder whether we really need such a long duration -- even when the tests are marked as slow, they shouldn't be unnecessarily slow. -- To view, visit https://gerrit.ovirt.org/40053 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id66dbd420ca29d08ae4063dc83b858be34b8940f Gerrit-PatchSet: 48 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
