Francesco Romani has posted comments on this change. Change subject: migration: Add DynamicThrottling semaphores ......................................................................
Patch Set 18: (1 comment) https://gerrit.ovirt.org/#/c/53304/18/lib/vdsm/virt/utils.py File lib/vdsm/virt/utils.py: PS18, Line 123: DynamicBoundedSemaphore I cannot and won't insist on this because this is a feeling rather than a tecnhical observation (I have a couple of concerns about this, stated in the tests). I still feel that this is something like a WaitingQueue, a dynamically resizable WaitingQueue. When we resize it to make it bigger, it is easy. Same if we resize it to make it smaller, and there is spare room to use. But if we make it smaller than the current number of waiting clients, what should we do? Maybe nothing? Maybe serve them in a FIFO discipline (thus evicting the most recent waiters)? Perhaps evict the oldest waiters? -- To view, visit https://gerrit.ovirt.org/53304 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67376d0bd990f89e0a013887cef1a0cb05fb855d Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
