Maor Lipchuk has posted comments on this change. Change subject: storage: Move mount module to vdsm storage lib. ......................................................................
Patch Set 11: (3 comments) https://gerrit.ovirt.org/#/c/55292/11/lib/vdsm/storage/Makefile.am File lib/vdsm/storage/Makefile.am: Line 26: constants.py \ Line 27: exception.py \ Line 28: persistent.py \ Line 29: securable.py \ Line 30: mount.py \ > please arrange by alpha-bait order Done Line 31: sync.py \ https://gerrit.ovirt.org/#/c/55292/11/tests/mkimageTests.py File tests/mkimageTests.py: Line 35: from monkeypatch import Patch Line 36: from testlib import VdsmTestCase, permutations, expandPermutations Line 37: from testValidation import checkSudo, ValidateRunningAsRoot Line 38: Line 39: from vdsm import storage > Good catch! Done Line 40: from vdsm import udevadm Line 41: from vdsm.commands import execCmd Line 42: from vdsm.utils import stopwatch Line 43: import mkimage https://gerrit.ovirt.org/#/c/55292/11/vdsm/mkimage.py File vdsm/mkimage.py: Line 31: DISKIMAGE_USER, DISKIMAGE_GROUP Line 32: from vdsm import storage Line 33: from vdsm.constants import P_VDSM_RUN Line 34: from vdsm.commands import execCmd Line 35: from vdsm.utils import rmFile > move here Done Line 36: from storage.fileUtils import resolveUid, resolveGid Line 37: Line 38: _P_PAYLOAD_IMAGES = os.path.join(P_VDSM_RUN, 'payload') Line 39: -- To view, visit https://gerrit.ovirt.org/55292 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ee9fab87abcabc469c15256ba12386112a100e0 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
