Piotr Kliczewski has posted comments on this change. Change subject: migration: Enable lazy setting of incoming/outgoing limits ......................................................................
Patch Set 20: Code-Review-1 (3 comments) https://gerrit.ovirt.org/#/c/53305/20/lib/api/vdsmapi-schema.json File lib/api/vdsmapi-schema.json: Line 7749: # @VM.migrationCreate: Line 7750: # Line 7751: # Start a migrating VM on a destination host. Line 7752: # Line 7753: # @vmID: The UUID of the VM Please align descriptions for each parameter in line. Line 7754: # Line 7755: # @params: The VM definition Line 7756: # Line 7757: # @incomingLimit: Maximum number of incoming migrations Line 7753: # @vmID: The UUID of the VM Line 7754: # Line 7755: # @params: The VM definition Line 7756: # Line 7757: # @incomingLimit: Maximum number of incoming migrations You mark this param as optional '*' and I do not see it in description. Line 7758: # Line 7759: # Returns: Line 7760: # Migration creation state Line 7761: # https://gerrit.ovirt.org/#/c/53305/20/vdsm/API.py File vdsm/API.py: PS20, Line 584: int( We defined it as uint in schema. Why it is needed? -- To view, visit https://gerrit.ovirt.org/53305 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79ab97f15788e4024c94d051e4aade713d760acf Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
