Nir Soffer has posted comments on this change. Change subject: hsm: add uploaded image verification ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/55746/2/lib/api/vdsmapi-schema.json File lib/api/vdsmapi-schema.json: Line 8504: 'postZero': 'bool', 'force': 'bool'}, Line 8505: 'returns': 'UUID'} Line 8506: Line 8507: ## Line 8508: # @Volume.verify_upload: > We need a more generic name, something about verifying unsafe image. How about verify_untrusted_volume? Stolen from your allowIllegal patch :-) Line 8509: # Line 8510: # Verify an uploaded image's volume. The verification includes comparing Line 8511: # the uploaded image's format with the format that is specified in the Line 8512: # image's volume's metadata, and if the format is QCOW, verifying that -- To view, visit https://gerrit.ovirt.org/55746 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf85061536eb4ddff021539c742a674f183a8984 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
