Dan Kenigsberg has posted comments on this change. Change subject: new API call getVersionInfo() ......................................................................
Patch Set 4: I would prefer that you didn't submit this (5 inline comments) .................................................... File vdsm_api/vdsmapi-schema.json Line 1518: # @VdsmCapabilities: Line 1519: # Line 1520: # Host information and capabilities. Line 1521: # Line 1522: # @version_name: The name given to this version of VDSM I do not think this is useful information Line 1523: # Line 1524: # @software_version: VDSM version (x.y.z) Line 1525: # Line 1526: # @software_revision: Extra VDSM version information Line 1520: # Host information and capabilities. Line 1521: # Line 1522: # @version_name: The name given to this version of VDSM Line 1523: # Line 1524: # @software_version: VDSM version (x.y.z) can we call this simply "version"? Line 1525: # Line 1526: # @software_revision: Extra VDSM version information Line 1527: # Line 1528: # @supportedRHEVMs: A list of supported ovirt-engine versions Line 1522: # @version_name: The name given to this version of VDSM Line 1523: # Line 1524: # @software_version: VDSM version (x.y.z) Line 1525: # Line 1526: # @software_revision: Extra VDSM version information this is intended to be the complete "release" value from rpm? Line 1527: # Line 1528: # @supportedRHEVMs: A list of supported ovirt-engine versions Line 1529: # Line 1530: # @supportedProtocols: A list of supported xmlrpc protocol versions Line 1526: # @software_revision: Extra VDSM version information Line 1527: # Line 1528: # @supportedRHEVMs: A list of supported ovirt-engine versions Line 1529: # Line 1530: # @supportedProtocols: A list of supported xmlrpc protocol versions is there any use case for exposing this ? Line 1531: # Line 1532: # @clusterLevels: A list of supported cluster versions Line 1533: # Line 1534: # Since: 4.10.1 Line 1528: # @supportedRHEVMs: A list of supported ovirt-engine versions Line 1529: # Line 1530: # @supportedProtocols: A list of supported xmlrpc protocol versions Line 1531: # Line 1532: # @clusterLevels: A list of supported cluster versions please add a "bag" of capability flags Line 1533: # Line 1534: # Since: 4.10.1 Line 1535: # Line 1536: ## -- To view, visit http://gerrit.ovirt.org/8431 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f55ef437ca404ca04598d34c41756b1e68ced95 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Peter V. Saveliev <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
