Francesco Romani has posted comments on this change. Change subject: hostdev: expose parameters needed to support hotunplug ......................................................................
Patch Set 11: Code-Review+1 (1 comment) fine, but too hard to read, hence partial ACK. please make easier to read to get full ACK. https://gerrit.ovirt.org/#/c/54939/11/vdsm/virt/vmdevices/hostdevice.py File vdsm/virt/vmdevices/hostdevice.py: PS11, Line 65: return ('./devices/hostdev/source/address{}'.format( : ''.join(['[@{key}=\'{base}{value:{padding}}\']'.format( : key=key, value=int(value), **_padding(key)) for : key, value in self.hostAddress.items()]))) this is too packed, please decompress this (clever) line in something easier to digest -- To view, visit https://gerrit.ovirt.org/54939 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09e879051b1d47e48e9ae73c1f7d9bfbea8f1237 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
