Nir Soffer has posted comments on this change. Change subject: hsm: add untrusted image verification. ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/55746/4/vdsm/storage/hsm.py File vdsm/storage/hsm.py: Line 1505: @public Line 1506: def verify_untrusted_volume(self, spUUID, sdUUID, imgUUID, volUUID): Line 1507: dom = sdCache.produce(sdUUID=sdUUID) Line 1508: vol = dom.produceVolume(imgUUID, volUUID) Line 1509: actual_info = qemuimg.info(vol.getVolumePath()) > I didn't get your comment - we have two "infos" here - I agree, the error should not mention upload. Line 1510: Line 1511: expected_format = volume.FMT2STR[vol.getFormat()] Line 1512: actual_format = actual_info["format"] Line 1513: if expected_format != actual_format: -- To view, visit https://gerrit.ovirt.org/55746 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf85061536eb4ddff021539c742a674f183a8984 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches