Adam Litke has posted comments on this change. Change subject: HA: Make getHostLeaseStatus API public ......................................................................
Patch Set 6: Code-Review+1 (2 comments) https://gerrit.ovirt.org/#/c/29157/6/client/vdsClient.py File client/vdsClient.py: Line 1837: Line 1838: def getHostLeaseStatus(self, args): Line 1839: domains = {} Line 1840: for pair in args: Line 1841: sdUUID, hostId = pair.split('=', 1) > Why? Is this more common in vdsClient? vdsClient is all over the map. Given that we're going to dismantle this beast soon anyway I don't want to spend any more time than is necessary on it. Let's keep it like you have it. Line 1842: domains[sdUUID] = int(hostId) Line 1843: response = self.s.getHostLeaseStatus(domains) Line 1844: if response['status']['code']: Line 1845: print("Cannot get host storage liveliness") https://gerrit.ovirt.org/#/c/29157/6/lib/api/vdsmapi-schema.json File lib/api/vdsmapi-schema.json: Line 2300: # Line 2301: # Since: 4.18 Line 2302: ## Line 2303: {'map': 'HostLeaseStatusMap', Line 2304: 'key': 'UUID', 'value': 'str'} > No, host ids are unique per domain. Currently engine is using the same id o ok Line 2305: Line 2306: ## Line 2307: # @Host.getHostLeaseStatus: Line 2308: # -- To view, visit https://gerrit.ovirt.org/29157 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I415c1fee6256bf8d4e03ee542cc58e193162e9b8 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
