Edward Haas has posted comments on this change. Change subject: net: find toplevel iterface name based on net attributes ......................................................................
Patch Set 2: Code-Review-1 (3 comments) https://gerrit.ovirt.org/#/c/55323/2/lib/vdsm/netconfpersistence.py File lib/vdsm/netconfpersistence.py: Line 30: from . import commands Line 31: from . import constants Line 32: from . import utils Line 33: from vdsm.network.canonicalize import canonicalize_networks Line 34: from vdsm.network.utils import toplevel_iface junkyard alert! ;) what about this: (?) from vdsm.network.interface import toplevel I think we have many interface related utils/tools we can move there. it can also become a nice api to kernel interfaces. Line 35: Line 36: CONF_RUN_DIR = constants.P_VDSM_RUN + 'netconf/' Line 37: # The persistent path is inside of an extra "persistence" dir in order to get Line 38: # oVirt Node to persist the symbolic links that are necessary for the https://gerrit.ovirt.org/#/c/55323/2/tests/network/unit_test.py File tests/network/unit_test.py: PS2, Line 45: test_vlan test_vlan_with_nic PS2, Line 51: test_bond Don't we need two separate tests here? test_bond & test_vlan_with_bond -- To view, visit https://gerrit.ovirt.org/55323 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieb6ec043091eed6b3b0d8b3b66924aed66af3e12 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
