Zhou Zheng Sheng has posted comments on this change.
Change subject: Fix some pep8 errors in storageServer.py
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(3 inline comments)
I locate a few blank line problems. Since the patch is not aimed for 100% PEP
8, those problems can be ignored. If we have time, we can fix those problems.
Examine the patch using pydiff, it finds some changes like adjusting the import
order of storage_exception, adding a intermediate variable "interval", and
changing != and == to "is not" and "is" when comparing to "None". All are
acceptable.
....................................................
File vdsm/storage/storageServer.py
Line 114: def dict2conInfo(d):
Line 115: conType = d['type']
Line 116: params = _TYPE_NT_MAPPING[conType](d.get('params', {}))
Line 117: return ConnectionInfo(conType, params)
Line 118:
I think an extra blank line is needed here.
Line 119: def _addIntegerOption(options, key, value):
Line 120: try:
Line 121: options.append("%s=%d" % (key, int(value)))
Line 122: except ValueError:
Line 119: def _addIntegerOption(options, key, value):
Line 120: try:
Line 121: options.append("%s=%d" % (key, int(value)))
Line 122: except ValueError:
Line 123: raise se.InvalidParameterException(key, value)
I think an extra blank line is needed here.
Line 124:
Line 125: class ExampleConnection(object):
Line 126: """Do not inherit from this object it is just to show and
document the
Line 127: connection object interface"""
Line 269: pass
Line 270:
Line 271: # Return -1 to signify the version has not been negotiated yet
Line 272: return -1
Line 273:
Seems only one blank line is needed here.
Line 274:
Line 275: def __init__(self, export, timeout=600, retrans=6, version=3):
Line 276: self._remotePath = normpath(export)
Line 277: options = self.DEFAULT_OPTIONS[:]
--
To view, visit http://gerrit.ovirt.org/8606
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e40dbf8f441d83f5314921af4acba9980ec3f9f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
