Francesco Romani has posted comments on this change. Change subject: utils: build cert paths in single place ......................................................................
Patch Set 1: (2 comments) concept is fine IMO, but I'd polish a bit the implementation. https://gerrit.ovirt.org/#/c/52354/1/lib/vdsm/sslutils.py File lib/vdsm/sslutils.py: PS1, Line 162: tils.monotonic_time() this is a good idea, but to do it by the book, better split this formatting change: 1. one patch that moves from "from vdsm.utils import monotonic_time" to "import utils" (use utils facilities wherever needed) nothing else 2. this patch that uses the new function to get the ssl paths. https://gerrit.ovirt.org/#/c/52354/1/lib/vdsm/tool/configurators/certificates.py File lib/vdsm/tool/configurators/certificates.py: PS1, Line 39: get_cert_paths It is a good idea to have a central place to get this data. But I'd avoid to dump this in utils.py. Could be worth its own module alltogether. -- To view, visit https://gerrit.ovirt.org/52354 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58dd3a5f7c1503fc38b6c6a204c036c06d09941b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
