Petr Horáček has posted comments on this change. Change subject: net: netinfo: report switch type as legacy ......................................................................
Patch Set 4: -Verified (3 comments) https://gerrit.ovirt.org/#/c/55810/4//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2016-04-07 14:38:51 +0200 Line 4: Commit: Petr Horáček <phora...@redhat.com> Line 5: CommitDate: 2016-04-07 16:24:10 +0200 Line 6: Line 7: net: netinfo: report switch type > .. as legacy Done Line 8: Line 9: We report all networks with switch type 'legacy'. It has to be changed Line 10: to 'ovs' in OVS capabilities handling. Line 11: PS4, Line 9: It has to be changed : to 'ovs' in OVS capabilities handling. : : This (and the whole OVS relying on running config) should be replaced : with reporting of the actual system state. > It was a bit confusing for me, what about: Done https://gerrit.ovirt.org/#/c/55810/4/lib/vdsm/kernelconfig.py File lib/vdsm/kernelconfig.py: Line 236 Line 237 Line 238 Line 239 Line 240 > I think we cannot drop this normalization. Done -- To view, visit https://gerrit.ovirt.org/55810 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00c1267bee9c3a8fb45b72a483e0999139abaa8d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
