Greg Padgett has posted comments on this change. Change subject: Fix version handling for NFS ......................................................................
Patch Set 2: Looks good to me, but someone else must approve (1 inline comment) Just one nit, looks good otherwise. .................................................... File vdsm/storage/storageServer.py Line 267: return -1 Line 268: Line 269: def __init__(self, export, timeout=600, retrans=6, version=None): Line 270: self._remotePath = normpath(export) Line 271: self._version = version Same as line 274 Line 272: options = self.DEFAULT_OPTIONS[:] Line 273: self._timeout = timeout Line 274: self._version = version Line 275: self._retrans = retrans -- To view, visit http://gerrit.ovirt.org/8573 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I404df524419c663accf0890eb860c5a3afb81583 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
