Adam Litke has posted comments on this change. Change subject: tests: Test storagetestlib FakeEnv functions ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/55889/2/tests/storagetestlibTests.py File tests/storagetestlibTests.py: Line 60: for f in files: Line 61: path = os.path.join(image_dir, f) Line 62: self.assertTrue(os.path.exists(path)) Line 63: Line 64: def test_domain_metadata_io(self): > Can we group the domain and volume tests? Combine them how? All four of those as one combined test? Line 65: with fake_file_env() as env: Line 66: desc = 'foo' Line 67: set_domain_metaparams(env.sd_manifest, {sd.DMDK_DESCRIPTION: desc}) Line 68: -- To view, visit https://gerrit.ovirt.org/55889 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65ab8c6419dfa1181efff2a533c00589ba5b8263 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
