Michal Skrivanek has posted comments on this change. Change subject: migration: added logging of more detailed stats ......................................................................
Patch Set 1: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/55976/1/vdsm/virt/migration.py File vdsm/virt/migration.py: Line 566: Line 567: memSize = int(self._vm.conf['memSize']) Line 568: maxTimePerGiB = config.getint('vars', Line 569: 'migration_max_time_per_gib_mem') Line 570: migrationMaxTime = (maxTimePerGiB * memSize + 1023) / 1024 can we log this value as well? Line 571: lastProgressTime = time.time() Line 572: lowmark = None Line 573: self._execute_init(self._conv_schedule['init']) Line 574: Line 576: self._stop.wait(self._MIGRATION_MONITOR_INTERVAL) Line 577: (jobType, timeElapsed, _, Line 578: dataTotal, dataProcessed, dataRemaining, Line 579: memTotal, memProcessed, memRemaining, Line 580: fileTotal, fileProcessed, _) = self._vm._dom.jobInfo() IIRC jobStats is a superset of jobInfo. I guess we can replae the call instead of adding a new one Line 581: # from libvirt sources: data* = file* + mem*. Line 582: # docs can be misleading due to misaligned lines. Line 583: now = time.time() Line 584: self.log_migration_stats() -- To view, visit https://gerrit.ovirt.org/55976 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0b81c77b62e52190bfb9fe857105389d75d11e4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
