Martin Polednik has posted comments on this change. Change subject: Revert "hostdev: don't implicitly reattach devices" ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/56013/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1256: pass Line 1257: Line 1258: cleanup_guest_socket(self._guestSocketFile) Line 1259: Line 1260: def _reattachHostDevices(self): > can we do this - maybe in a later patch - only for NICs? It doesn't really change the fact that engine/networking code should not depend on the driver providing interface on top of device AFTER it has already provided this information. Line 1261: # reattach host devices Line 1262: for dev_name, _ in self._host_devices(): Line 1263: self.log.debug('Reattaching device %s to host.' % dev_name) Line 1264: try: -- To view, visit https://gerrit.ovirt.org/56013 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia46068b4905d480e50957d3611bd9ae74e45a77d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
