Francesco Romani has posted comments on this change. Change subject: hostdev: expose generic scsi driver char device in device params ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/55022/3/lib/vdsm/hostdev.py File lib/vdsm/hostdev.py: PS3, Line 167: try: : udev_path = caps.find('char').text : except AttributeError: : # Is not scsi char device. : pass : else: : params['udev_path'] = udev_path this works. I think it is a bit clearer if we do: char_node = caps.find('char') if char_node is not None: params['udev_path'] = char_node.text (feel free to rename char_node to udev_path or whatever) -- To view, visit https://gerrit.ovirt.org/55022 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91e6793e946310b57e3004cbebc286cc6e00a724 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches