Francesco Romani has posted comments on this change.

Change subject: hostdev: use libvirt flags to select capability
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/56037/1/lib/vdsm/hostdev.py
File lib/vdsm/hostdev.py:

PS1, Line 214:     if caps:
             :         flags |= sum([_LIBVIRT_DEVICE_FLAGS[cap] for cap in 
caps])
> KeyError in this case is really evil and we have to explode.
fine


-- 
To view, visit https://gerrit.ovirt.org/56037
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia40fff8ba0bace1272666825d6c4fce18ac9a1f0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <[email protected]>
Gerrit-Reviewer: gerrit-hooks <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to