Dan Kenigsberg has posted comments on this change.

Change subject: Enable python3 over fedora as default and disable it over 
centos\rhel
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.ovirt.org/#/c/56072/3/configure.ac
File configure.ac:

Line 69: AS_IF([test "${enable_vhostmd}" = "yes"],
Line 70:       AC_SUBST([VHOSTMD], ['1']),
Line 71:       AC_SUBST([VHOSTMD], ['0']))
Line 72: 
Line 73: if grep -q 'Fedora' /etc/redhat-release; then
how about disabling by default if the python3 package for "libvirt" is missing?

if python3 -m libvirt >2
Line 74:     fedora_run="yes"
Line 75: else
Line 76:     fedora_run="no"
Line 77: fi


PS3, Line 83: over centos and RHEL
when python3-libvirt is unavailable


-- 
To view, visit https://gerrit.ovirt.org/56072
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I610e4c0d27f12ab37b9dd5b1f5a53f5729627054
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Edward Haas <[email protected]>
Gerrit-Reviewer: Irit Goihman <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: gerrit-hooks <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to