Petr Horáček has posted comments on this change. Change subject: net: native ovs [5]: rollback trigger ......................................................................
Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/55312/6/lib/vdsm/network/ovs/switch.py File lib/vdsm/network/ovs/switch.py: Line 52: validator.validate_bond_configuration(attrs, _netinfo) Line 53: Line 54: Line 55: @contextmanager Line 56: def rollback_trigger(in_rollback): > Looking at this contextmanager here, it seems to me that it fits to be part it cannot be. with migration support it won't be possible to save and create RunningConfig here, but above for both rollback_triggers and save when both of them finish. Line 57: """Keep running_config and in case of an exception, trigger rollback.""" Line 58: running_config = RunningConfig() Line 59: try: Line 60: yield running_config -- To view, visit https://gerrit.ovirt.org/55312 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bceae0aada964c47aacfcfdbe93ca19eb8f3d15 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
