Milan Zamazal has posted comments on this change. Change subject: build: Make sure run_tests*.sh scripts are executable ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/55949/1/build-aux/Makefile.subs File build-aux/Makefile.subs: Line 38: Line 39: CONFIGSUBST = $(top_builddir)/config.status --file=- Line 40: Line 41: %.sh: %.sh.in Line 42: @echo " SED $@"; $(PATHSUBST) $< |$(CONFIGSUBST) >$@ > maybe you should have specific rules for this 2 scripts in tests/Makefile.a I tried it, unfortunately the paths are still wrong (indeed, Makefile.subs is included there so there is little real difference). I'm tempted to hardcode ".." into the scripts -- would it break anything? Line 43: chmod +x $@ Line 44: Line 45: %: %.in -- To view, visit https://gerrit.ovirt.org/55949 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc1e3dc8ace7f69801b765262352903020cc8aef Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
