Nir Soffer has submitted this change and it was merged. Change subject: blockVolume: Move _calculate_volume_alloc_size to Manifest ......................................................................
blockVolume: Move _calculate_volume_alloc_size to Manifest _calculate_volume_alloc_size contains logic that is generally useful for creating new block volumes. Move it to the BlockVolumeManifest class (and make it public) so that it can be used by the SDM VolumeArtifacts class in the future. Change-Id: I53e0a5f231a91a0405a5cad4133fd52f6db79f63 Signed-off-by: Adam Litke <[email protected]> Reviewed-on: https://gerrit.ovirt.org/55986 Reviewed-by: Freddy Rolland <[email protected]> Reviewed-by: Nir Soffer <[email protected]> Continuous-Integration: Jenkins CI --- M tests/blockVolumeTests.py M tests/sdm_indirection_tests.py M vdsm/storage/blockVolume.py 3 files changed, 51 insertions(+), 35 deletions(-) Approvals: Adam Litke: Verified Nir Soffer: Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/55986 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I53e0a5f231a91a0405a5cad4133fd52f6db79f63 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
