Piotr Kliczewski has posted comments on this change. Change subject: asyncore: make sure to handle sslerror on send ......................................................................
Patch Set 1: Verified+1 I checked the sources of m2c and I can see that send can raise the same set of exceptions as recv. During several hrs of testing I haven't seen this issue occurring but it is matter of timing for it to happen so it is better to handle it cleanly instead of letting it to propagate. Based on above I am giving it conditional V +1. -- To view, visit https://gerrit.ovirt.org/56206 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28fd1accb04c74c8ed2f11ba47fa5ef7fee67883 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches