Dan Kenigsberg has posted comments on this change. Change subject: add -d parameter when umouning in mk_sysprep_floppy ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) have you actually seen this problem happen? mount(8) says Since Linux 2.6.25 is supported auto-destruction of loop devices and then any loop device allocated by mount will be freed by umount independently on /etc/mtab. this explains why I've never had a problem with this script. I do not deeply resent asking destruction of the loopback explicitly, I would just want to know if the problem is actual or theoretical. .................................................... File vdsm/mk_sysprep_floppy.in Line 32: /sbin/mkfs.msdos -C "$FLOPPY_NAME" 1440 Line 33: /bin/chown @VDSMUSER@:@QEMUGROUP@ "$FLOPPY_NAME" Line 34: /bin/chmod 0440 "$FLOPPY_NAME" Line 35: mntpoint=`mktemp -d` Line 36: mount -o loop,uid=`id -u`,gid=`id -g` "$FLOPPY_DIR/$FLOPPY_NAME" $mntpoint unrelated to this patch: $FLOPPY_DIR is never defined! it should be dropped to allow floppy creations with relative paths. Line 37: Line 38: /bin/cat > $mntpoint/sysprep.inf Line 39: Line 40: umount -d $mntpoint -- To view, visit http://gerrit.ovirt.org/8675 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3f964b50a38e8dc180d20f7e6687a092b7dc272 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Jarod.w <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jarod.w <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
