Vinzenz Feenstra has posted comments on this change. Change subject: use default libvirt event handler impl ......................................................................
Patch Set 1: I would prefer that you didn't submit this (2 inline comments) .................................................... File vdsm/libvirtconnection.py Line 125: for name in dir(libvirt.virConnect): Line 126: method = getattr(conn, name) Line 127: if callable(method) and name[0] != '_': Line 128: setattr(conn, name, wrapMethod(method)) Line 129: conn.setKeepAlive(5, 3) +1 for named parameters Line 130: .................................................... File vdsm/libvirtev.py Line 3: # Line 4: # Line 5: ########################################################################## Line 6: # Start off by implementing a general purpose event loop for anyones use Line 7: ########################################################################## If we keep this file please add back the license header. Line 8: import libvirt Line 9: import threading Line 10: Line 11: -- To view, visit http://gerrit.ovirt.org/5015 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I735d6b1f856b5a5b216d2dddf629c5ec80e8b7e7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Gal Hammer <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Royce Lv <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
