Francesco Romani has posted comments on this change. Change subject: virt: Introduction of the GuestAgentEvents class ......................................................................
Patch Set 6: Code-Review+1 (1 comment) seems ok, hence partial ack, but please check the question inside https://gerrit.ovirt.org/#/c/51781/6/lib/vdsm/virt/guestagent.py File lib/vdsm/virt/guestagent.py: PS6, Line 122: self._agent() In theory, this could be None if _agent is collected, so also in theory this method could raise AttributeError. In practice, due to how we use this code, I believe we should never hit this scenario, right? -- To view, visit https://gerrit.ovirt.org/51781 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9dde856aa43bf130e28ce1ebc8cc7dac0341f45 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches