Francesco Romani has posted comments on this change. Change subject: hostdev: add is_assignable flag ......................................................................
Patch Set 2: Code-Review+1 (1 comment) partial ACK, one question inside. https://gerrit.ovirt.org/#/c/56291/2/lib/vdsm/hostdev.py File lib/vdsm/hostdev.py: PS2, Line 155: not _pci_header_type(name) I prefer '_pci_header_type(name) == 0' for clarity. Or you con go another step further and provide constants for header types. This seems to me compatible with the direction https://www.redhat.com/archives/libvir-list/2016-March/msg00647.html is taking. -- To view, visit https://gerrit.ovirt.org/56291 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6fd0d39e777c6bc0f3175b737ace9be92df4cca0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
