Eduardo has posted comments on this change.

Change subject: Make sure teardown() is called in case of errors
......................................................................


Patch Set 1: I would prefer that you didn't submit this

No need for another prepare thing!

If "... should be use unless there is absolutely no other choice!" should 
replace the actual prepare().

Which cases have "The Choice"?

--
To view, visit http://gerrit.ovirt.org/8667
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cefbcd72434aa4d766b50b3d05aa70ba8cd910c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dafna Ron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to