Dan Kenigsberg has posted comments on this change. Change subject: Clean /rhev/data-center/mnt/ after failed mount command ......................................................................
Patch Set 2: I would prefer that you didn't submit this (2 inline comments) .................................................... File vdsm/storage/mount.py Line 200: out, err = p.communicate() Line 201: rc = p.returncode Line 202: Line 203: if rc == 0: Line 204: return rc what is this good for? Line 205: Line 206: raise MountError(rc, ";".join((out, err))) Line 207: Line 208: def umount(self, force=False, lazy=False, timeout=None): .................................................... File vdsm/storage/storageServer.py Line 205: except MountError: Line 206: try: Line 207: os.rmdir(self._getLocalPath()) Line 208: except OSError as e: Line 209: if e.errno != errno.ENOENT: why worry about ENOENT? we've just created this dir 10 lines above. Line 210: raise Line 211: Line 212: try: Line 213: fileSD.validateDirAccess(self.getMountObj().getRecord().fs_file) -- To view, visit http://gerrit.ovirt.org/8695 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91b11d11a6e3402fe40607847ee24b1fb539df22 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
