Francesco Romani has posted comments on this change. Change subject: vm: conf: proper locking in setNumberOfCpus() ......................................................................
Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/54910/6/tests/vmOperationsTests.py File tests/vmOperationsTests.py: PS6, Line 299: @permutations([[1], [2], [4], [16]]) : def testSetNumberOfVcpus(self, smp): > looking at testSetNumberOfVcpusFailed, don't we need similar protection for good point -- To view, visit https://gerrit.ovirt.org/54910 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20822e31af1e7350833d9c3080efc5d0f79a5cbe Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
