Petr Horáček has posted comments on this change. Change subject: net: OVS driver ......................................................................
Patch Set 16: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/55958/16/lib/vdsm/network/ovs/driver/vsctl.py File lib/vdsm/network/ovs/driver/vsctl.py: Line 171: Line 172: def attach_bond_slave(self, bond, slave): Line 173: command = [ Line 174: '--id=@%s' % slave, 'create', 'Interface', 'name=%s' % slave, Line 175: '--', 'add', 'Port', bond, 'interfaces', '@%s' % slave] Here's a bug. We add two commands at once, this fails when try to parse output, because of number of result rows does not match number of commands. Line 176: return Command(command) Line 177: Line 178: def detach_bond_slave(self, bond, slave): Line 179: command = ['--', '--id=@%s' % slave, 'get', 'Interface', slave, '--', -- To view, visit https://gerrit.ovirt.org/55958 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic24a9cea8d50e801de12da1c9cfcd2d195aed684 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
