Adam Litke has posted comments on this change. Change subject: tests: FakeLVM: Always create lv file ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/56169/2/tests/storagefakelibTests.py File tests/storagefakelibTests.py: Line 279: lvm.activateLVs(self.VG_NAME, [self.LV_NAME]) Line 280: lv = lvm.getLV(self.VG_NAME, self.LV_NAME) Line 281: self.assertTrue(lv.active) Line 282: self.assertEqual('a', lv.attr.state) Line 283: self.assertTrue(os.path.exists(lv_path)) > test the fake file size. new test that creates an lv, activates it, writes data and is then able to read. Line 284: Line 285: def test_changevgtags(self): Line 286: with self.base_config() as lvm: Line 287: deltags = (blockSD.STORAGE_UNREADY_DOMAIN_TAG,) -- To view, visit https://gerrit.ovirt.org/56169 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia364588a9fbe3a987b9117522db025e92c8ed296 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
