Adam Litke has posted comments on this change. Change subject: VolumeMetadata: Add from_lines factory method ......................................................................
Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/52672/3//COMMIT_MSG Commit Message: Line 8: Line 9: Add support for creating a VolumeMetadata instance from a list of lines. Line 10: This is the format that can be read from either block or file based Line 11: volume metadata and enables us to consolidate the logic into one place. Line 12: Add comment that we now raise when integer values were expected in from_lines() Line 13: Change-Id: Id7f63dce8e42e99d3240f4e916a9bd6ee5ee4b61 https://gerrit.ovirt.org/#/c/52672/3/tests/storage_volume_metadata_test.py File tests/storage_volume_metadata_test.py: Line 105: self.assertRaises(TypeError, volume.VolumeMetadata.from_lines, []) Line 106: Line 107: def test_from_lines_invalid_param(self): Line 108: self.assertRaises(se.VolumeMetadataReadError, Line 109: volume.VolumeMetadata.from_lines, ["FOO=bar"]) this doesn't raise anymore. Line 110: Line 111: def test_from_lines_invalid_format(self): Line 112: lines = ["DOMAIN=domain", "IMAGE=image", "PUUID=parent", "SIZE=FOO", Line 113: "FORMAT=format", "TYPE=type", "VOLTYPE=voltype", -- To view, visit https://gerrit.ovirt.org/52672 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7f63dce8e42e99d3240f4e916a9bd6ee5ee4b61 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
